Repository navigation
fix: surface mapStateToProps errors in connect - #2311
louzhedong wants to merge 1 commit into
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
mapStateToProps errors in connect
|
Quick follow-up in case this is easier to review now than the other This change is intentionally narrow. It only re-surfaces If you'd prefer this handled in a different layer of |
|
#2306 already logs these errors in development, and this approach rethrows the saved error even after a later store update or new props would let mapStateToProps succeed. That breaks the existing "throws once, then recovers" test. We're also trying to keep connect behavior changes to a minimum right now. Given that, I'm going to go ahead and close this. Thanks! |
This makes
connectrethrow subscription callback errors during render somapStateToPropsfailures can reach an error boundary instead of being swallowed.Validation: